Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update the workflows #48

Closed
wants to merge 66 commits into from
Closed

ci: update the workflows #48

wants to merge 66 commits into from

Conversation

ali-hosseini-deriv
Copy link
Owner

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

nada-deriv and others added 10 commits August 10, 2023 13:37
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…ry-com#9155)

* feat: add test for trade modal

* refactor: test for trade modals

* chore: correct grammar

* chore: correct typo

* refactor: apply sugestions

* refactor: incapsulated trade providers

* chore: rename function

* chore: change function name
…dContractModal in Trader package (binary-com#9074)

* feat: add tests for modals

* refactor: add values to the mock store

* refactor: change default values
…der (binary-com#8521)

* test: ts migration and test coverage for ServicesErrorModal folder

* fix: circle CI issue and migration/test of constants

* fix: circlci

* fix: circlci errors
…il" (binary-com#9574)

* refactor: 🎨 groups checkbox elements together

* feat: ✨ adds desclaimer checkbox for country brazil

* style: 💄 styles modal for checkbox

* refactor: 🎨 refactors checkbox for brazil

* test: 🧪 adds test cases

* test: 🧪 fixes test cases

* test: 🧪 moves mock props to global scope

* refactor: 🎨 removes unused imports

* style: 💄 fixes alignment as per figma design

* style: 💄 removes modal height limiting for auto resizing

* build: 🚧 trigger build
* chore: updated slack webhook URL

* chore: updated slack webhook URL
@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 0:00am

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Generating Lighthouse report...

github-actions bot and others added 17 commits August 15, 2023 11:06
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…age (binary-com#9464)

* feat: add unit tests

* refactor: incapsulated trade providers
…-com#8398)

* refactor: add integr and unit tests for loader

* refactor: removed hardcoded test id
* fix: 🐛 display onfido error message

* fix: reverted change

* test: ✅ added testcases

* fix: test case names

* fix: added testcases
binary-com#8483)

* fix: test coverage and ts migration for asset/trading/categories

* fix: codecov issues

* fix: codecov issues

* test: dynamic test component import

* fix: code smell add error handling

* fix: change from FC to componenttype

* fix: circleCi

* fix: circleCI

* fix: circleCi

* fix: failing test

* fix: circleCI
* chore: adding Korean language

* chore: changed Korean short form to KO from KR

* chore: fix translation issue in login history table

* chore: update all flags to follow the latest design system

* chore: Korean language on P2P

* chore: update deriv-charts to v1.3.2

* chore: empty

* translations: 📚 sync translations with crowdin (binary-com#9607)

Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>

* chore: empty

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix: disable account when proof failed

* fix: disable account when proof failed

* fix: flag

* fix: import

* fix: update with master
…om#9336)

* fix: 🐛 translation of IDV documents dropdown option

* fix: 🐛 translation of default config

* fix: 🐛 translation of default config

* fix: 🐛 removed unused-import

* fix: 🐛 refactored code

* fix: ♻️ incorporated review comments

* fix: 🐛 added missing function
…itionsMobile (binary-com#9610)

* feat: handle displayed positions locally in mobile TogglePositions

* test: added a test

* chore: refactoring

* test: fix tests after conflict resolution
…bile browsers (binary-com#9620)

* fix: completed order modal is not showing in mobile

* fix: add test case, fix error in chat component upon creating order

* refactor: destructure order in handleResponse
…ods in buy/sell page (binary-com#8544)

* Create codeql.yml

* Create codeql-test.yml

* chore: removed codeql workflows

* chore: removed dccache

* chore: added escapeHtml function to login

* feat: added new flow for filter modal

* chore: removed old commits

* fix: fixed ui issues regarding requirements

* feat: changed reset flow

* feat: changed flow for reset, added status for filter modal icon

* chore: incorporated reviews

* chore: applied code review changes
…-com#9064)

* fix: notifications_in_cashier_and_accounts

* fix: notification for maintenance

* fix: notification_filter

* fix: notification_filter

* fix: filter notifications in mobile

* fix: code_review_suggestions

* chore: merge master

* chore: resolve conflict

* fix: showing notification in mobile
* feat: ✨ adds financial assessment notification

* refactor: 🎨 sorts the object block

* feat: ✨ displays financial assessment notification on trigger from backend

* chore: 🚑 resolves merge conflict with master

* test: 🧪 adds test case for app-notification

* test: 🧪 adds test cases for notification
* chore: change text

* chore: apply suggestion
@coveralls
Copy link
Collaborator

coveralls commented Aug 18, 2023

Pull Request Test Coverage Report for Build 5911194713

  • 414 of 719 (57.58%) changed or added relevant lines in 137 files are covered.
  • 3789 unchanged lines in 70 files lost coverage.
  • Overall coverage increased (+0.4%) to 10.135%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/account/src/App.tsx 0 1 0.0%
packages/account/src/Sections/Security/TwoFactorAuthentication/two-factor-authentication.jsx 0 1 0.0%
packages/bot-skeleton/src/services/api/active-symbols.js 0 1 0.0%
packages/cashier/src/app.tsx 0 1 0.0%
packages/cashier/src/components/divider/divider.tsx 1 2 50.0%
packages/cashier/src/components/funds-protection/funds-protection.tsx 1 2 50.0%
packages/cashier/src/modules/cashier-onboarding/components/cashier-onboarding-crypto-card/cashier-onboarding-crypto-card.tsx 6 7 85.71%
packages/cashier/src/modules/cashier-onboarding/components/cashier-onboarding-onramp-card/cashier-onboarding-onramp-card.tsx 7 8 87.5%
packages/cashier/src/modules/cashier-onboarding/components/cashier-onboarding-p2p-card/cashier-onboarding-p2p-card.tsx 6 7 85.71%
packages/cashier/src/modules/cashier-onboarding/components/cashier-onboarding-side-notes/cashier-onboarding-side-note-crypto.tsx 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
packages/account/src/App.tsx 1 0%
packages/account/src/Sections/Verification/ProofOfIdentity/proof-of-identity-submission-for-mt5.jsx 1 0%
packages/cashier/src/app-content.tsx 1 0%
packages/cashier/src/app.tsx 1 0%
packages/cashier/src/modules/cashier-onboarding/components/cashier-onboarding-p2p-card/cashier-onboarding-p2p-card.tsx 1 82.5%
packages/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.tsx 1 81.25%
packages/cashier/src/pages/deposit/deposit.tsx 1 54.17%
packages/cashier/src/pages/withdrawal/withdrawal-verification-email/withdrawal-verification-email.tsx 1 0%
packages/components/src/components/vertical-tab/vertical-tab-content-container.tsx 1 0%
packages/core/src/App/Containers/AccountSignupModal/account-signup-modal.jsx 1 0%
Totals Coverage Status
Change from base Build 5830440207: 0.4%
Covered Lines: 10170
Relevant Lines: 83811

💛 - Coveralls

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 19, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Oct 25, 2023
ali-hosseini-deriv pushed a commit that referenced this pull request Jan 8, 2024
* refactor: 🎨 migrated component to TSX (#48)

* refactor: 🎨 migrated component to TSX

* refactor: ⚰️ unused import

* fix: 🎨 migrated config to tsx (binary-com#49)

* refactor: migrated components to tsx

* refactor: migrated components to tsx

* chore: added testcases

* chore: added testcases

* Merge branch 'master' into sprint-10/account-package-refactor

* fix: 🧪 fixed failing testcase

* fix: 🧪 fixed failing testcase

* Likhith/migrate poo form (binary-com#50)

* refactor: removed dead code

* chore: fixed error condition

* chore: update from master

* fix: error object props

* chore: poo ts init (binary-com#53)

* chore: poo ts init

* chore: remove query

* chore: some types fix

* chore: revert observer for poo form

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>

* feat: refactored POO form values

* fix: Error text for Failure of IDV

* fix: file upload

* fix: POO validation

* fix: failing testcase

* fix: added validations

* fix: types of payment method

* fix: testcases for POO

* fix: code smells

* fix: resolved code smells

* refactor: types errors (binary-com#58)

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>

* fix: resolved code smells

* fix: code smells

* fix: async behavior

* fix: import constant

* fix: rename Const

* refactor: sonarcloud issues

* fix: incorporated review comments

* fix: Convert the conditional to a boolean to avoid leaked value

* fix: incorporated review comments

* refactor: incorporated review comments

* fix: removed duplicate status

* chore: poo-form review comments

* fix: code smells

* fix: failing testcase

* fix: wrong upload settings field name

* chore: unused import remove

* fix: duplicate filling of payment-method

* fix: removed unused import

* fix:reset form

* fix: resolved error display bugs

* Merge branch 'master' into sprint-10/account-package-refactor

* fix: issue related with POO disble

* fix: code smells

* fix: code smells

* refactor: incorporated review comments

* fix: removed prop drilling

* fix: incorporated useFileUploader hook

* refactor: removed hook implementation

* fix: resolved loading and validation

* fix: incorrect status display issue

* chore: removed console statements

* fix: reinitialize form on value change

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
ali-hosseini-deriv pushed a commit that referenced this pull request Feb 16, 2024
…2443)

* feat: create play stop controller

* refactor: improve volume controller

* fix: ui and volume bugs

* refactor: functions helpers

* refactor: remove extra animation

* refactor: apply first part of suggestions

* refactor: upgrade dropdown component

* refactor: remove inline style

* refactor: add more ref

* refactor: add flag for animation instead of inline style

* refactor: add extra ref and remove inline style for volume control

* fix: revert browser check

* feat: add scroll functionality

* refactor: recalculate scroll heigh

* chore: fix typo

* chore: apply suggestions

* refactor: make srcrollbar visible for player

* refactor: add tests for overlay, volume and playback rate files

* refactor: add tests for video control file and apply suggestion

* refactor: style nesting

* refactor: remove sonarcloud smell

* refactor: get rid of extra ref usage

* refactor: add tests for browser detect function

* refactor: add tests for formatduration function

* refactor: typos

* Maryia/test: VideoPlayer + optimization (#48)

* test: VideoPlayer

* refactor: type TMockedStreamProps

* test: VideoPlayer

* chore: optimization & improvements

* test: add test for video player (replay feature)

* refactor: rename refs

* chore: voluma and animation fixes

* chore: volume control functions refactor

* refactor: change rounding

* fix: autoplaying after switching tabs

* refactor: improve animation

* fix: gap berween drag dot and progress bar

* refactor: reworked animationframe

* refactor: remove use effect

* refactor: improve perfomance

* fix: Safari issues for long living tabs

* refactor: ad debounce and cleaning

* refactor: ad debounce and cleaning

* refactor: fix tests

* fix: mobile control pannel

* fix: first launch time issue

* refactor: change type of th check for rewind

* refactor: apply suggestions

---------

Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.